Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

Issue 2459113002: [IDBObservers] Moving options from constructor to .observe call. (Closed)
Patch Set: added more exceptions, fixed tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
index e82160cc587341cd37f9d3a222706bddea1ab300..8beb875bf878be441c328d9dbd935fe8f94f3fdb 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp
@@ -10,7 +10,6 @@
#include "bindings/core/v8/V8DOMWrapper.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/modules/v8/IDBObserverCallback.h"
-#include "bindings/modules/v8/V8IDBObserverInit.h"
namespace blink {
@@ -39,9 +38,6 @@ void V8IDBObserver::constructorCustom(
return;
}
- IDBObserverInit idbObserverInit;
- V8IDBObserverInit::toImpl(info.GetIsolate(), info[1], idbObserverInit,
- exceptionState);
if (exceptionState.hadException())
return;
@@ -49,7 +45,7 @@ void V8IDBObserver::constructorCustom(
v8::Local<v8::Function> v8Callback = v8::Local<v8::Function>::Cast(info[0]);
IDBObserverCallback* callback =
IDBObserverCallback::create(scriptState, v8Callback);
- IDBObserver* observer = IDBObserver::create(callback, idbObserverInit);
+ IDBObserver* observer = IDBObserver::create(callback);
if (exceptionState.hadException())
return;
DCHECK(observer);

Powered by Google App Engine
This is Rietveld 408576698