Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2459073003: [Mac] Implement an active state for the avatar button (Closed)

Created:
4 years, 1 month ago by spqchan
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Implement an active state for the avatar button BUG=654876 Committed: https://crrev.com/d7387b36c1f7bf70cedbf7a4661386a2c336bdc9 Cr-Commit-Position: refs/heads/master@{#429633}

Patch Set 1 #

Patch Set 2 : Missing comment #

Patch Set 3 : Updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/profiles/avatar_base_controller.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
spqchan
PTAL
4 years, 1 month ago (2016-10-29 00:57:43 UTC) #6
spqchan
On 2016/10/29 00:57:43, spqchan wrote: > PTAL ping
4 years, 1 month ago (2016-11-02 23:06:29 UTC) #7
shrike
Sorry for the delay. lgtm
4 years, 1 month ago (2016-11-02 23:55:31 UTC) #8
spqchan
thanks! +avi for ownership
4 years, 1 month ago (2016-11-02 23:56:54 UTC) #10
Avi (use Gerrit)
lgtm stampity stamp
4 years, 1 month ago (2016-11-03 14:37:00 UTC) #11
spqchan
On 2016/11/03 14:37:00, Avi wrote: > lgtm > > stampity stamp thanks!
4 years, 1 month ago (2016-11-03 17:05:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459073003/40001
4 years, 1 month ago (2016-11-03 17:06:20 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 17:35:59 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:48:14 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d7387b36c1f7bf70cedbf7a4661386a2c336bdc9
Cr-Commit-Position: refs/heads/master@{#429633}

Powered by Google App Engine
This is Rietveld 408576698