Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Issue 2459033002: 📰 Add a context menu to remove status items (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index e3d2e684d26137dec45af731625c4a86024748d2..64eded006af0d513dc30d7ac759225ba9c1fb706 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -6,6 +6,7 @@
import android.annotation.SuppressLint;
import android.graphics.Canvas;
+import android.support.annotation.StringRes;
import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.RecyclerView.Adapter;
import android.support.v7.widget.RecyclerView.ViewHolder;
@@ -336,7 +337,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
return new NewTabPageViewHolder(SpacingItem.createView(parent));
case ItemViewType.STATUS:
- return new StatusCardViewHolder(mRecyclerView, mUiConfig);
+ return new StatusCardViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
case ItemViewType.PROGRESS:
return new ProgressViewHolder(mRecyclerView);
@@ -345,7 +346,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
return new ActionItem.ViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
case ItemViewType.PROMO:
- return new SignInPromo.ViewHolder(mRecyclerView, mUiConfig);
+ return new SignInPromo.ViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
case ItemViewType.FOOTER:
return new Footer.ViewHolder(mRecyclerView, mNewTabPageManager);
@@ -536,6 +537,9 @@ public void dismissItem(int position) {
private void dismissSection(SuggestionsSection section) {
assert SnippetsConfig.isSectionDismissalEnabled();
+
+ announceItemRemoved(section.getHeaderText());
+
mNewTabPageManager.getSuggestionsSource().dismissCategory(section.getCategory());
removeSection(section);
}
@@ -559,7 +563,7 @@ private void dismissSuggestion(int position) {
}
private void dismissPromo() {
- // TODO(dgn): accessibility announcement.
+ announceItemRemoved(mSigninPromo.getHeader());
mSigninPromo.dismiss();
}
@@ -637,4 +641,11 @@ private void announceItemRemoved(String suggestionTitle) {
mRecyclerView.announceForAccessibility(mRecyclerView.getResources().getString(
R.string.ntp_accessibility_item_removed, suggestionTitle));
}
+
+ private void announceItemRemoved(@StringRes int stringToAnnounce) {
+ // In tests the RecyclerView can be null.
+ if (mRecyclerView == null) return;
+
+ announceItemRemoved(mRecyclerView.getResources().getString(stringToAnnounce));
+ }
}

Powered by Google App Engine
This is Rietveld 408576698