chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java - Issue 2459033002: 📰 Add a context menu to remove status items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2459033002: 📰 Add a context menu to remove status items (Closed)

Patch Set: close the menu when the view is detached Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusCardViewHolder.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

index 6d9e1b303821a8ba3a4276d8e0240d544d0d1aaa..36c44a23ba89840754fee5dadad9769aa43fbd16 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

@@ -121,7 +121,7 @@ public void openItem(int windowDisposition) {

@Override

public void removeItem() {

- getRecyclerView().dismissItemWithAnimation(mArticle);

+ getRecyclerView().dismissItemWithAnimation(this);

}

@Override

@@ -134,7 +134,7 @@ public boolean canBeSavedOffline() {

@Override

protected void createContextMenu(ContextMenu menu) {

new ContextMenuHandler(mNewTabPageManager, getRecyclerView(), this)

- .onCreateContextMenu(menu);

+ .onCreateContextMenu(menu, itemView);

}

/**