third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp - Issue 2459003003: WTF/std normalization: replace WTF::Vector::removeLast with ::pop_back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

Issue 2459003003: WTF/std normalization: replace WTF::Vector::removeLast with ::pop_back (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScope.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

index 2d3925b55523cc2d7d6e357b1fd10764117b31bc..7e1a51f65582ca4958ef80c6df9a15a7b353cf67 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp

@@ -135,7 +135,7 @@ CustomElementDefinition::ConstructionStackScope::~ConstructionStackScope() {

DCHECK(!m_constructionStack.last() ||

m_constructionStack.last() == m_element);

DCHECK_EQ(m_constructionStack.size(), m_depth); // It's a *stack*.

- m_constructionStack.removeLast();

+ m_constructionStack.pop_back();

}

// https://html.spec.whatwg.org/multipage/scripting.html#concept-upgrade-an-element