Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issue 2459003003: WTF/std normalization: replace WTF::Vector::removeLast with ::pop_back (Closed)

Created:
4 years, 1 month ago by pilgrim_google
Modified:
4 years, 1 month ago
CC:
ajuma+watch-canvas_chromium.org, ajuma+watch_chromium.org, alex clarke (OOO till 29th), darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gasubic, Nate Chapin, jbroman, jchaffraix+rendering, jsbell, Justin Novosad, kinuko+fileapi, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Mikhail, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, nhiroki, ojan, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sof, nessy, Srirama, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, tzik, vcarbune.chromium, webcomponents-bugzilla_chromium.org, Yuta Kitamura, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF/std normalization: replace WTF::Vector::removeLast with ::pop_back As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. This CL replaces removeLast() with pop_back(). There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208 Cr-Commit-Position: refs/heads/master@{#429930}

Patch Set 1 #

Patch Set 2 : one too many in NormalizeAlgorithm #

Patch Set 3 : missed a platform-specific one in Canvas2DLayerBridge.cpp #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementReactionStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/vtt/VTTParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BidiRunForLine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vibration/VibrationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/ContextMenu.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PathTraversalState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (22 generated)
pilgrim_google
4 years, 1 month ago (2016-11-03 20:04:19 UTC) #15
haraken
LGTM Remove "WTF/std normalization: replace WTF::Vector::emplaceAppend with ::emplace_back" from the CL description. Also please create ...
4 years, 1 month ago (2016-11-03 23:49:34 UTC) #18
Yuta Kitamura
LGTM In addition to what haraken said, please fix the URL in the change description ...
4 years, 1 month ago (2016-11-04 05:50:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459003003/60001
4 years, 1 month ago (2016-11-04 16:15:39 UTC) #25
pilgrim_google
On 2016/11/04 at 05:50:49, yutak wrote: > LGTM > > In addition to what haraken ...
4 years, 1 month ago (2016-11-04 16:16:35 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-04 17:23:15 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:36:49 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c9e1380ae7c169501892b25f1ee82e04207e9208
Cr-Commit-Position: refs/heads/master@{#429930}

Powered by Google App Engine
This is Rietveld 408576698