Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 24590002: MIPS: Less aggressive polling when concurrently compiling for OSR. (Closed)

Created:
7 years, 2 months ago by kilvadyb
Modified:
7 years, 2 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Less aggressive polling when concurrently compiling for OSR. Port r16934 (b12e96b) Original commit message: Changes include: - completed concurrent OSR tasks trigger a stack check interrupt. - polling for completion is now guarded by a stack check. - circular buffer for completed OSR tasks instead of list. BUG=

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -61 lines) Patch
M src/mips/builtins-mips.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +55 lines, -61 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kilvadyb
7 years, 2 months ago (2013-09-25 14:49:43 UTC) #1
Yang
https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc#newcode972 src/mips/builtins-mips.cc:972: __ stop("check1"); You probably want to remove this :)
7 years, 2 months ago (2013-09-25 14:54:37 UTC) #2
Paul Lind
https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc#newcode972 src/mips/builtins-mips.cc:972: __ stop("check1"); You probably should remove this ... ;-) ...
7 years, 2 months ago (2013-09-25 15:05:00 UTC) #3
kilvadyb
Thank you for catching it. https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc File src/mips/builtins-mips.cc (right): https://codereview.chromium.org/24590002/diff/1/src/mips/builtins-mips.cc#newcode972 src/mips/builtins-mips.cc:972: __ stop("check1"); On 2013/09/25 ...
7 years, 2 months ago (2013-09-25 15:14:28 UTC) #4
Paul Lind
LGTM. I'll land this for you.
7 years, 2 months ago (2013-09-25 16:25:31 UTC) #5
Paul Lind
7 years, 2 months ago (2013-09-25 16:29:01 UTC) #6
Committed as r16947.

Powered by Google App Engine
This is Rietveld 408576698