Issue 2458983002: [wasm] Start function must not have a return value.

Issue 2458983002: [wasm] Start function must not have a return value. (Closed)

Created:
4 years, 1 month ago by ahaas

Modified:
4 years, 1 month ago

Reviewers:
titzer

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[wasm] Start function must not have a return value. R=titzer@chromium.org TEST=mjsunit/wasm/start-function Committed: https://crrev.com/aff3ef21080e0abf83c6edc0c34acc702f6e698f Cr-Commit-Position: refs/heads/master@{#40646}

Created: 4 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+8 lines, -16 lines)
	M	src/wasm/module-decoder.cc	View	1 chunk	+4 lines, -2 lines	0 comments
	M	test/mjsunit/wasm/start-function.js	View	2 chunks	+4 lines, -14 lines	0 comments

Total messages: 12 (6 generated)

titzer

lgtm Looks like we explicitly allowed it before on purpose, which is not spec :(

4 years, 1 month ago (2016-10-28 13:15:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458983002/1

4 years, 1 month ago (2016-10-28 13:33:11 UTC) #8

ahaas

On 2016/10/28 at 13:15:38, titzer wrote: > lgtm > > Looks like we explicitly allowed ...

4 years, 1 month ago (2016-10-28 13:33:32 UTC) #9

commit-bot: I haz the power

4 years, 1 month ago (2016-11-17 22:16:49 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/aff3ef21080e0abf83c6edc0c34acc702f6e698f
Cr-Commit-Position: refs/heads/master@{#40646}