Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2458973002: Audio input traces for Mac (browser-side) (Closed)

Created:
4 years, 1 month ago by o1ka
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mac-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Traces for browser-side audio capturing on Mac: Timing for steps of getting data from the device(AudioUnit) and passing it through FIFOs to shared memory and finally signalling "data ready" to renderer through a socket. BUG=660360 Committed: https://crrev.com/5b8dc212f9b61bd1b8e725e5a347fdbf033f7a54 Cr-Commit-Position: refs/heads/master@{#428372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 4 chunks +7 lines, -0 lines 0 comments Download
M media/audio/audio_input_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/audio/mac/audio_input_mac.cc View 3 chunks +6 lines, -1 line 0 comments Download
M media/audio/mac/audio_low_latency_input_mac.cc View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
o1ka
tommi@ PTAL
4 years, 1 month ago (2016-10-28 13:33:42 UTC) #9
tommi (sloooow) - chröme
lgtm. can you update the description to briefly describe what's being measured and why?
4 years, 1 month ago (2016-10-28 13:39:55 UTC) #10
tommi (sloooow) - chröme
On 2016/10/28 13:39:55, tommi (chrömium) wrote: > lgtm. can you update the description to briefly ...
4 years, 1 month ago (2016-10-28 13:40:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458973002/80001
4 years, 1 month ago (2016-10-28 14:52:43 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 1 month ago (2016-10-28 14:57:48 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 15:01:37 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b8dc212f9b61bd1b8e725e5a347fdbf033f7a54
Cr-Commit-Position: refs/heads/master@{#428372}

Powered by Google App Engine
This is Rietveld 408576698