Add Shell::PrintErr and expose it in the d8 shell as printErr

Add Shell::PrintErr and expose it in the d8 shell as printErr

This function is implemented in other JavaScript shells

BUG=None

R=titzer

Committed: https://crrev.com/fb96618ee01b70e88b997a60194548bfcc2f26e8
Cr-Commit-Position: refs/heads/master@{#40677}

[jgravelle, 2016-10-28 18:03:59]

The CQ bit was checked by jgravelle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 18:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:07:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:07:36]

Dry run: Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27530)

[jgravelle, 2016-10-28 20:23:09]

The CQ bit was checked by jgravelle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 20:23:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 20:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:47:51]

Dry run: This issue passed the CQ dry run.

[jgravelle, 2016-10-28 21:13:04]

jgravelle@chromium.org changed reviewers:
+ ahaas@chromium.org
- titzer@chromium.org

[jgravelle, 2016-10-28 21:13:04]

Not sure if the test I added is reasonable/sufficient, but I'm not sure what the
best way to test printing to stderr from JS would be. Any suggestions?

[Derek Schuff, 2016-10-28 22:04:38]

dschuff@chromium.org changed reviewers:
+ dschuff@chromium.org

[Derek Schuff, 2016-10-28 22:04:39]

https://codereview.chromium.org/2458963003/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2458963003/diff/20001/src/d8.cc#newcode967
src/d8.cc:967: Write(args);
why not just `WriteToFile(stdout, args)`? Is `Write` used anywhere else?

[jgravelle, 2016-10-28 22:17:25]

https://codereview.chromium.org/2458963003/diff/20001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2458963003/diff/20001/src/d8.cc#newcode967
src/d8.cc:967: Write(args);
On 2016/10/28 22:04:39, Derek Schuff wrote:
> why not just `WriteToFile(stdout, args)`? Is `Write` used anywhere else?

Write gets exposed to JS so most likely yes.
There's more symmetry here as WriteToFile(stdout, args) though. I was erring on
the side of "change as little as possible" but that's cleaner yeah.

[ahaas, 2016-10-31 12:11:20]

ahaas@chromium.org changed reviewers:
+ yangguo@chromium.org

[ahaas, 2016-10-31 12:11:42]

On 2016/10/31 at 12:11:20, ahaas wrote:
> ahaas@chromium.org changed reviewers:
> + yangguo@chromium.org

Yang, could you please take a look?

[Yang, 2016-10-31 12:14:21]

On 2016/10/31 12:11:42, ahaas wrote:
> On 2016/10/31 at 12:11:20, ahaas wrote:
> > mailto:ahaas@chromium.org changed reviewers:
> > + mailto:yangguo@chromium.org
> 
> Yang, could you please take a look?

lgtm.

[jgravelle, 2016-10-31 16:11:12]

The CQ bit was checked by jgravelle@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:11:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgravelle, 2016-10-31 16:11:19]

The CQ bit was unchecked by jgravelle@chromium.org

[jgravelle, 2016-10-31 16:11:32]

The CQ bit was checked by jgravelle@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:11:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:39:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:18:21]

Description was changed from

==========
Add Shell::PrintErr and expose it in the d8 shell as printErr

This function is implemented in other JavaScript shells

BUG=None

R=titzer
==========

to

==========
Add Shell::PrintErr and expose it in the d8 shell as printErr

This function is implemented in other JavaScript shells

BUG=None

R=titzer

Committed: https://crrev.com/fb96618ee01b70e88b997a60194548bfcc2f26e8
Cr-Commit-Position: refs/heads/master@{#40677}
==========

[commit-bot: I haz the power, 2016-11-17 22:18:22]

Patchset 3 (id:??) landed as
https://crrev.com/fb96618ee01b70e88b997a60194548bfcc2f26e8
Cr-Commit-Position: refs/heads/master@{#40677}