Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2458963002: Disable flaky testWebAppSplashscreenIsDownloaded test. (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky testWebAppSplashscreenIsDownloaded test. I commented out @SmallTest etc since almost all instances of DisabledTest in code search also commented SmallTest out. That doesn't make any sense to me though; surely commenting out cannot be necessary unless DisabledTest has no effect at all on the test runner? BUG=660237 TBR=dfalcantara@chromium.org Committed: https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57 Cr-Commit-Position: refs/heads/master@{#428331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
phoglund_chromium
4 years, 1 month ago (2016-10-28 10:36:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458963002/1
4 years, 1 month ago (2016-10-28 10:36:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 11:05:01 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/329928769e9fdcb0cdd1766adcdc39130fe6fc57 Cr-Commit-Position: refs/heads/master@{#428331}
4 years, 1 month ago (2016-10-28 11:06:27 UTC) #9
dominickn
4 years, 1 month ago (2016-10-30 22:53:19 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2461273002/ by dominickn@chromium.org.

The reason for reverting is: The offending CL that caused the failures has been
reverted (crrev.com/2362033002).

Powered by Google App Engine
This is Rietveld 408576698