Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2458953002: Fix PrerenderBrowserTest.AutosigninInPrerenderer flakiness. (Closed)
Patch Set: TODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index b6f790c852164df2a639e9748964cc31608f7420..31ee3cb6beb5616397b0f6e8f78c4bacc15c360b 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -3217,9 +3217,7 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, HttpPost) {
// Prerenders a page that tries to automatically sign user in via the Credential
// Manager API. The page should be killed.
-//
-// Disabled. See http://crbug.com/660278
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, DISABLED_AutosigninInPrerenderer) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, AutosigninInPrerenderer) {
// Set up a credential in the password store.
PasswordStoreFactory::GetInstance()->SetTestingFactory(
current_browser()->profile(),
@@ -3251,6 +3249,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, DISABLED_AutosigninInPrerenderer) {
BrowserThread::IO, FROM_HERE,
base::Bind(&CreateCountingInterceptorOnIO,
done_url, empty_file, done_counter.AsWeakPtr()));
+ // Loading may finish or be interrupted. The final result is important only.
+ // TODO(http://crbug.com/660278): TestPrrenderContents can be created after
+ // the JS code runs. The result would be a test timeout.
+ DisableLoadEventCheck();
PrerenderTestURL("/password/autosignin.html",
FINAL_STATUS_CREDENTIAL_MANAGER_API, 0);
EXPECT_EQ(0, done_counter.count());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698