Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245893005: [Cast] Consolidate plethora of GYP files into cast.gyp and cast_testing.gypi. (Closed)

Created:
6 years, 8 months ago by miu
Modified:
6 years, 8 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

[Cast] Consolidate plethora of GYP files into cast.gyp and cast_testing.gypi. The proliferation of GYP files in the src/media/cast directory hierarchy has made refactoring efforts difficult to manage. This change reduces everything down to one GYP (plus one GYPI for the testing targets). This change was tested by building on Linux: `build/gyp_chromium && ninja -C out/Debug All` Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265481

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -833 lines) Patch
M chrome/chrome_browser.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D media/cast/audio_receiver/audio_receiver.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D media/cast/audio_sender/audio_sender.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
M media/cast/cast.gyp View 1 chunk +215 lines, -139 lines 0 comments Download
D media/cast/cast_config.gyp View 1 chunk +0 lines, -29 lines 0 comments Download
D media/cast/cast_receiver.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
D media/cast/cast_sender.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
A media/cast/cast_testing.gypi View 1 chunk +219 lines, -0 lines 0 comments Download
D media/cast/congestion_control/congestion_control.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
D media/cast/framer/framer.gyp View 1 chunk +0 lines, -31 lines 0 comments Download
D media/cast/logging/logging.gyp View 1 chunk +0 lines, -92 lines 0 comments Download
D media/cast/rtcp/rtcp.gyp View 1 chunk +0 lines, -56 lines 0 comments Download
D media/cast/rtp_receiver/rtp_parser/rtp_parser.gyp View 1 chunk +0 lines, -27 lines 0 comments Download
D media/cast/rtp_receiver/rtp_receiver.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
D media/cast/test/utility/utility.gyp View 1 chunk +0 lines, -91 lines 0 comments Download
D media/cast/transport/cast_transport.gyp View 1 chunk +0 lines, -49 lines 0 comments Download
D media/cast/transport/utility/utility.gyp View 1 chunk +0 lines, -26 lines 0 comments Download
D media/cast/video_receiver/video_receiver.gypi View 1 chunk +0 lines, -32 lines 0 comments Download
D media/cast/video_sender/codecs/vp8/vp8_encoder.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D media/cast/video_sender/video_sender.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/message_lib.gyp View 1 chunk +1 line, -1 line 0 comments Download
M tools/ipc_fuzzer/mutate/mutate.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
miu
hclam: PTAL.
6 years, 8 months ago (2014-04-22 20:27:29 UTC) #1
Alpha Left Google
Looks like everything compiles. LGTM.
6 years, 8 months ago (2014-04-22 21:19:21 UTC) #2
miu
The CQ bit was checked by miu@chromium.org
6 years, 8 months ago (2014-04-22 21:45:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/245893005/20001
6 years, 8 months ago (2014-04-22 21:46:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 22:06:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-22 22:06:56 UTC) #6
miu
The CQ bit was checked by miu@chromium.org
6 years, 8 months ago (2014-04-22 22:09:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/245893005/20001
6 years, 8 months ago (2014-04-22 22:11:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 22:38:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_clang_dbg
6 years, 8 months ago (2014-04-22 22:38:41 UTC) #10
miu
The CQ bit was checked by miu@chromium.org
6 years, 8 months ago (2014-04-22 22:50:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/245893005/20001
6 years, 8 months ago (2014-04-22 22:50:26 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-23 01:56:58 UTC) #13
Message was sent while issue was closed. 
Change committed as 265481

Powered by Google App Engine
This is Rietveld 408576698