Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2458903002: Split javascript_dialogs.cc into views and cocoa+views versions. (Closed)
Patch Set: -build_config.h Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index c7ae261a74903c02f6cdcc705c3bab1e580a54c2..b9ee3dabf46d0253fbc1875479079e874750f97b 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -727,10 +727,7 @@ split_static_library("ui") {
"global_error/global_error_service_factory.h",
"infobar_container_delegate.cc",
"infobar_container_delegate.h",
- "javascript_dialogs/javascript_dialog.cc",
"javascript_dialogs/javascript_dialog.h",
- "javascript_dialogs/javascript_dialog_cocoa.h",
- "javascript_dialogs/javascript_dialog_cocoa.mm",
"javascript_dialogs/javascript_dialog_tab_helper.cc",
"javascript_dialogs/javascript_dialog_tab_helper.h",
"javascript_dialogs/javascript_dialog_views.cc",
@@ -1574,6 +1571,8 @@ split_static_library("ui") {
}
if (!is_mac || mac_views_browser) {
sources += [
+ "javascript_dialogs/javascript_dialog.cc",
+
# This test header is included because it contains forward declarations
# needed for "friend" statements for use in tests.
"translate/translate_bubble_test_utils.h",
@@ -2918,6 +2917,9 @@ split_static_library("ui") {
# See crbug.com/590850
"content_settings/content_setting_media_menu_model.cc",
"content_settings/content_setting_media_menu_model.h",
+ "javascript_dialogs/javascript_dialog_cocoa.h",
+ "javascript_dialogs/javascript_dialog_cocoa.mm",
+ "javascript_dialogs/javascript_dialog_mac.cc",
"proximity_auth/proximity_auth_error_bubble_stub.cc",
]
}
« no previous file with comments | « no previous file | chrome/browser/ui/javascript_dialogs/javascript_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698