Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2458853003: Do nothing if [changeFile] reported, but the file content is the same. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do nothing if [changeFile] reported, but the file content is the same. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1ffda5601ba5af87248ae87d58e8cf6fcda48d8b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +17 lines, -7 lines 2 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-10-28 21:08:37 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as 1ffda5601ba5af87248ae87d58e8cf6fcda48d8b (presubmit successful).
4 years, 1 month ago (2016-10-28 21:08:56 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-10-31 14:06:04 UTC) #4
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2458853003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2458853003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:331: * files that that change in
the file might affect.
"that that" --> "that the"

https://codereview.chromium.org/2458853003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:694: // If the file content hash
is the same, we don't need analyzing it.
"need analyzing it" --> "need to analyze it"

Powered by Google App Engine
This is Rietveld 408576698