exo: Replace fling cancel with generic zero distance scroll

exo: Replace fling cancel with generic zero distance scroll

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

[denniskempin, 2016-10-27 22:31:02]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[reveman, 2016-10-31 02:25:13]

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (left):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc#o...
components/exo/pointer.cc:251:
delegate_->OnPointerScrollCancel(event->time_stamp());
can we remove OnPointerScrollCancel from the delegate interface?

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:293: if ((event->flags() & ui::EF_IS_SYNTHESIZED) ==
0)
can we merge this with the "event->flags() & ui::EF_IS_SYNTHESIZED" if statement
above?

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.h
File components/exo/pointer.h (right):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.h#ne...
components/exo/pointer.h:114: // Last received event type
nit: s/type/type./

[denniskempin, 2016-10-31 17:33:49]

all done

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (left):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc#o...
components/exo/pointer.cc:251:
delegate_->OnPointerScrollCancel(event->time_stamp());
On 2016/10/31 02:25:12, reveman wrote:
> can we remove OnPointerScrollCancel from the delegate interface?

Done.

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:293: if ((event->flags() & ui::EF_IS_SYNTHESIZED) ==
0)
On 2016/10/31 02:25:12, reveman wrote:
> can we merge this with the "event->flags() & ui::EF_IS_SYNTHESIZED" if
statement
> above?

Done.

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.h
File components/exo/pointer.h (right):

https://codereview.chromium.org/2458853002/diff/1/components/exo/pointer.h#ne...
components/exo/pointer.h:114: // Last received event type
On 2016/10/31 02:25:13, reveman wrote:
> nit: s/type/type./

Done.

[reveman, 2016-10-31 18:14:19]

lgtm with optional nits

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:269: if ((event->flags() & ui::EF_IS_SYNTHESIZED) ==
0) {
nit: chromium style is "if (!(event->flags() & ui::EF_IS_SYNTHESIZED)) {" but
this is not regression from before so fee free to ignore this if you like

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:270: is_direct_input_ = (event->flags() &
ui::EF_DIRECT_INPUT) != 0;
nit: s/(event->flags() & ui::EF_DIRECT_INPUT) != 0;/event->flags() &
ui::EF_DIRECT_INPUT;/

[denniskempin, 2016-10-31 22:08:35]

All done!

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:269: if ((event->flags() & ui::EF_IS_SYNTHESIZED) ==
0) {
On 2016/10/31 18:14:19, reveman wrote:
> nit: chromium style is "if (!(event->flags() & ui::EF_IS_SYNTHESIZED)) {" but
> this is not regression from before so fee free to ignore this if you like

Done.

https://codereview.chromium.org/2458853002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:270: is_direct_input_ = (event->flags() &
ui::EF_DIRECT_INPUT) != 0;
On 2016/10/31 18:14:19, reveman wrote:
> nit: s/(event->flags() & ui::EF_DIRECT_INPUT) != 0;/event->flags() &
> ui::EF_DIRECT_INPUT;/

Done.

[denniskempin, 2016-10-31 22:08:46]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-10-31 22:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2458853002/#ps60001
(title: "fixed nits")

[commit-bot: I haz the power, 2016-10-31 22:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 00:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 00:34:44]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[denniskempin, 2016-11-14 19:35:39]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-11-14 19:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 20:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 20:53:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[denniskempin, 2016-12-06 22:37:34]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-12-06 22:38:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:40:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)