Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 2458843003: Fix TODO style in password_generation_agent.mm (Closed)

Created:
4 years, 1 month ago by vabr (Chromium)
Modified:
4 years, 1 month ago
Reviewers:
dvadym
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mac-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TODO style in password_generation_agent.mm This CL replaces a TODO(dconnelly) with a TODO mentioning a bug. It also removes two obsolete TODOs, which were referring to http://crbug.com/434679. That bug is marked as WontFix, because the refactoring plans have been superseded by the current Blink Onion Soup efforts. BUG=543839, 433856, 434679 R=dvadym@chromium.org Committed: https://crrev.com/5865ee59d31f23e443b04140884446fc596c7adb Cr-Commit-Position: refs/heads/master@{#428340}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ios/chrome/browser/passwords/password_generation_agent.mm View 3 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
vabr (Chromium)
Hi Vadym, PTAL. Thanks! Vaclav
4 years, 1 month ago (2016-10-28 11:05:14 UTC) #3
dvadym
On 2016/10/28 11:05:14, vabr (Chromium) wrote: > Hi Vadym, > PTAL. > Thanks! > Vaclav ...
4 years, 1 month ago (2016-10-28 11:25:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458843003/1
4 years, 1 month ago (2016-10-28 11:54:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 11:59:39 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 12:04:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5865ee59d31f23e443b04140884446fc596c7adb
Cr-Commit-Position: refs/heads/master@{#428340}

Powered by Google App Engine
This is Rietveld 408576698