Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2458833002: Remove ios/testing/earl_grey/wait_util. (Closed)

Created:
4 years, 1 month ago by baxley
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ios/testing/earl_grey/wait_util. This has been replaced by ios/testing/wait_util. BUG=658859 Committed: https://crrev.com/0bfd9e5f65fcd7b26bbf23a33e18f3fb3454f169 Cr-Commit-Position: refs/heads/master@{#428850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -50 lines) Patch
M ios/testing/earl_grey/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ios/testing/earl_grey/wait_util.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ios/testing/earl_grey/wait_util.mm View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
baxley
This needs to wait to land until downstream dependencies are removed, which is inflight.
4 years, 1 month ago (2016-10-28 23:36:36 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 1 month ago (2016-10-28 23:47:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458833002/1
4 years, 1 month ago (2016-10-31 21:24:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 22:39:42 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 22:42:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bfd9e5f65fcd7b26bbf23a33e18f3fb3454f169
Cr-Commit-Position: refs/heads/master@{#428850}

Powered by Google App Engine
This is Rietveld 408576698