Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: net/spdy/server_push_delegate.h

Issue 2458793002: Server push cancellation: add PushPromiseHelper which reflects information on the push promise. (Closed)
Patch Set: address rch's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/server_push_delegate.h
diff --git a/net/spdy/server_push_delegate.h b/net/spdy/server_push_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..b4094df8539c3a6c74489f329c1ffd7bfeccbe69
--- /dev/null
+++ b/net/spdy/server_push_delegate.h
@@ -0,0 +1,35 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SPDY_SERVER_PUSH_DELEGATE_H_
+#define NET_SPDY_SERVER_PUSH_DELEGATE_H_
+
+#include "net/base/net_export.h"
+#include "url/gurl.h"
+
+namespace net {
+
+class NET_EXPORT ServerPushDelegate {
Ryan Hamilton 2016/11/08 22:27:01 Nit: Class comment, please. NET_EXPORT or NET_EXP
Zhongyi Shi 2016/11/09 19:07:41 Done.
+ public:
+ // An interface to a class that reflects information on the pushed request.
+ class NET_EXPORT ServerPushHelper {
+ public:
+ virtual ~ServerPushHelper() {}
+
+ // Cancels the push if it is not claimed yet.
+ virtual void Cancel() = 0;
+
+ // Gets the URL of the pushed request.
+ virtual const GURL& GetURL() = 0;
+ };
+
+ virtual ~ServerPushDelegate() {}
+
+ // Invoked by session when a push promise has been received.
+ virtual void OnPush(std::unique_ptr<ServerPushHelper> push_helper) = 0;
+};
+
+} // namespace net
+
+#endif // NET_SPDY_PUSH_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698