Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: net/quic/core/quic_client_session_base.h

Issue 2458793002: Server push cancellation: add PushPromiseHelper which reflects information on the push promise. (Closed)
Patch Set: address rch's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_client_session_base.h
diff --git a/net/quic/core/quic_client_session_base.h b/net/quic/core/quic_client_session_base.h
index f73081f72aa54fb644d26c6639343b6bda89bf47..cb35e6dd2fcb39d643a266b71a2d72a7c69ca7ae 100644
--- a/net/quic/core/quic_client_session_base.h
+++ b/net/quic/core/quic_client_session_base.h
@@ -76,8 +76,9 @@ class NET_EXPORT_PRIVATE QuicClientSessionBase
// Called by |QuicSpdyClientStream| on receipt of PUSH_PROMISE, does
// some session level validation and creates the
// |QuicClientPromisedInfo| inserting into maps by (promised) id and
- // url.
- virtual void HandlePromised(QuicStreamId associated_id,
+ // url. Returns true if a new push promise is accepted. Reset the promised and
+ // returns false otherwiese.
+ virtual bool HandlePromised(QuicStreamId associated_id,
Ryan Hamilton 2016/11/08 22:27:01 You'll merge this back, right?
Buck 2016/11/08 22:51:28 Should tests quic_chromium_client_session_test.cc
Zhongyi Shi 2016/11/09 19:07:41 Yup.
QuicStreamId promised_id,
const SpdyHeaderBlock& headers);

Powered by Google App Engine
This is Rietveld 408576698