Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2458793002: Server push cancellation: add PushPromiseHelper which reflects information on the push promise. (Closed)

Created:
4 years, 1 month ago by Zhongyi Shi
Modified:
4 years, 1 month ago
Reviewers:
Buck, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Buck
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Server push cancellation: add PushPromiseHelper which reflects information on the push promise. Implement in both SPDY and QUIC. Also add PushDelegate which consumes the PushPromiseHelper. BUG=232040 Committed: https://crrev.com/7465c1b7e3a6d055488065d78c2348c21250e1a5 Cr-Commit-Position: refs/heads/master@{#431446}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : add PushDelegate #

Total comments: 18

Patch Set 4 : address rch's comments #

Total comments: 5

Patch Set 5 : Check whether push is validating before cancel #

Patch Set 6 : Sync with master #

Patch Set 7 : sync and fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -66 lines) Patch
M net/net.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.h View 1 2 3 4 5 4 chunks +9 lines, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 2 3 4 5 5 chunks +36 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 2 3 4 5 6 7 chunks +61 lines, -5 lines 0 comments Download
M net/quic/core/quic_client_promised_info.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info.cc View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 1 2 3 4 5 2 chunks +1 line, -28 lines 0 comments Download
M net/quic/core/quic_client_session_base.h View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 1 2 3 4 5 4 chunks +6 lines, -5 lines 0 comments Download
A net/spdy/server_push_delegate.h View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.h View 1 2 3 4 5 chunks +14 lines, -4 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 4 chunks +40 lines, -15 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 2 3 8 chunks +115 lines, -2 lines 0 comments Download
A net/tools/quic/test_tools/push_promise_delegate.h View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/push_promise_delegate.cc View 1 2 3 4 1 chunk +25 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 34 (20 generated)
Zhongyi Shi
So I realized that I have to create the PushDelegate to accept the PushPromiseHelper, this ...
4 years, 1 month ago (2016-10-27 19:59:40 UTC) #4
Ryan Hamilton
I'd prefer to land this when we either have tests or a consumer of it, ...
4 years, 1 month ago (2016-10-27 20:26:52 UTC) #5
Zhongyi Shi
Thanks for the suggestion. I added PushDelegate to this cl and implemented a test push ...
4 years, 1 month ago (2016-10-27 23:10:31 UTC) #7
Ryan Hamilton
looking good https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h File net/spdy/push_delegate.h (right): https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h#newcode14 net/spdy/push_delegate.h:14: class NET_EXPORT PushPromiseHelper { This class exists ...
4 years, 1 month ago (2016-10-28 00:32:22 UTC) #8
Zhongyi Shi
Thanks Ryan, PTAL and let me know your ideas! https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h File net/spdy/push_delegate.h (right): https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h#newcode14 net/spdy/push_delegate.h:14: ...
4 years, 1 month ago (2016-11-07 22:07:04 UTC) #10
Ryan Hamilton
Looks good. One comment about OnPush() https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h File net/spdy/push_delegate.h (right): https://codereview.chromium.org/2458793002/diff/60001/net/spdy/push_delegate.h#newcode30 net/spdy/push_delegate.h:30: virtual void OnPush(std::unique_ptr<PushPromiseHelper> ...
4 years, 1 month ago (2016-11-08 22:27:02 UTC) #11
Buck
https://codereview.chromium.org/2458793002/diff/100001/net/quic/core/quic_client_session_base.h File net/quic/core/quic_client_session_base.h (right): https://codereview.chromium.org/2458793002/diff/100001/net/quic/core/quic_client_session_base.h#newcode81 net/quic/core/quic_client_session_base.h:81: virtual bool HandlePromised(QuicStreamId associated_id, Should tests quic_chromium_client_session_test.cc that exercise ...
4 years, 1 month ago (2016-11-08 22:51:28 UTC) #13
Zhongyi Shi
Added extra checks before cancel the push. Unittest is also available testing cancel push when ...
4 years, 1 month ago (2016-11-09 19:07:41 UTC) #15
Buck
lgtm
4 years, 1 month ago (2016-11-09 19:34:53 UTC) #16
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-09 19:50:36 UTC) #19
Zhongyi Shi
Update: Fix newly added unittest in QuicChromiumClientSessionTest. Cause: It's failing upon teardown when the write ...
4 years, 1 month ago (2016-11-11 00:02:19 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458793002/240001
4 years, 1 month ago (2016-11-11 00:23:26 UTC) #30
commit-bot: I haz the power
Committed patchset #7 (id:240001)
4 years, 1 month ago (2016-11-11 01:39:29 UTC) #32
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 01:54:53 UTC) #34
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7465c1b7e3a6d055488065d78c2348c21250e1a5
Cr-Commit-Position: refs/heads/master@{#431446}

Powered by Google App Engine
This is Rietveld 408576698