Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2458773008: [wrapper-tracing] Fix EventTarget with LazyEventListeners (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/events/EventTarget.cpp
diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp
index a21200c0c9aeaf182adc17b47bb7e9bca96c90ce..4517c0ea14dcc2c9421e846aa1d6bc169e61e735 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.cpp
+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp
@@ -160,9 +160,6 @@ DEFINE_TRACE_WRAPPERS(EventTarget) {
continue;
V8AbstractEventListener* v8listener =
static_cast<V8AbstractEventListener*>(listener);
- if (!v8listener->hasExistingListenerObject())
- continue;
-
visitor->traceWrappers(v8listener);
}
}
@@ -305,10 +302,8 @@ bool EventTarget::addEventListenerInternal(
eventType, listener, options, &registeredListener);
if (added) {
if (listener->type() == EventListener::JSEventListenerType) {
- V8AbstractEventListener* v8listener =
- static_cast<V8AbstractEventListener*>(listener);
- if (v8listener->hasExistingListenerObject())
- ScriptWrappableVisitor::writeBarrier(this, v8listener);
+ ScriptWrappableVisitor::writeBarrier(
+ this, static_cast<V8AbstractEventListener*>(listener));
}
addedEventListener(eventType, registeredListener);
}
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698