Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: net/disk_cache/blockfile/addr.h

Issue 2458773003: Clarify that BlockSizeForFileType can't be called with EXTERNAL FileType (Closed)
Patch Set: pacify gcc Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/blockfile/addr.h
diff --git a/net/disk_cache/blockfile/addr.h b/net/disk_cache/blockfile/addr.h
index f21fbf2aa14000ccdd6f978a976ed238b4bc3099..32e035eac99aa66432653bc99a238016345e325e 100644
--- a/net/disk_cache/blockfile/addr.h
+++ b/net/disk_cache/blockfile/addr.h
@@ -11,6 +11,7 @@
#include <stddef.h>
#include <stdint.h>
+#include "base/logging.h"
#include "net/base/net_export.h"
#include "net/disk_cache/blockfile/disk_format_base.h"
@@ -138,9 +139,11 @@ class NET_EXPORT_PRIVATE Addr {
return 104;
case BLOCK_EVICTED:
return 48;
- default:
+ case EXTERNAL:
+ NOTREACHED();
return 0;
}
+ return 0;
}
static FileType RequiredFileType(int size) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698