Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2458763002: cros: Fixed 3 bugs for pin unlock. (Closed)

Created:
4 years, 1 month ago by jdufault
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

cros: Fixed 3 bugs for pin unlock. User name would flash on startup before the rest of the user pod. Pin keyboard would show up for users with disabled keyboards and the easy unlock icon would clash with the re-authentication icon. I hide the easy unlock icon whenever the re-authentication icon is shown. BUG=655221, 654300, 655308 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2427073002 Cr-Commit-Position: refs/heads/master@{#427152} (cherry picked from commit a77a4ddde837ba57fca3195127cd4f1ad8f96eab) Committed: https://chromium.googlesource.com/chromium/src/+/276b05086f2b3aafe37af09fe3d5a054abee8d05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/login/lock.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/login/account_picker/screen_account_picker.js View 2 chunks +11 lines, -4 lines 0 comments Download
M ui/login/account_picker/user_pod_row.css View 2 chunks +7 lines, -9 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
4 years, 1 month ago (2016-10-27 18:25:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
276b05086f2b3aafe37af09fe3d5a054abee8d05.

Powered by Google App Engine
This is Rietveld 408576698