Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.h

Issue 2458743003: Failure to parse full hash metadata shouldn't discard the response (Closed)
Patch Set: Nits: Updated comments from nparker@'s review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_get_hash_protocol_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/v4_get_hash_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.h b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
index fb736d905da5fe047256ef3855c4958c3401f923..0e9d005b1291db798e4b52fcd7d4460fe172a45e 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.h
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
@@ -271,10 +271,10 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,
std::vector<FullHashInfo>* full_hash_infos,
base::Time* negative_cache_expire);
- // Parses the store specific |metadata| information from |match|. Returns
- // true if the metadata information was parsed correctly and was consistent
- // with what's expected from that corresponding store; false otherwise.
- bool ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
+ // Parses the store specific |metadata| information from |match|. Logs errors
+ // to UMA if the metadata information was not parsed correctly or was
+ // inconsistent with what's expected from that corresponding store.
+ static void ParseMetadata(const ThreatMatch& match, ThreatMetadata* metadata);
// Resets the gethash error counter and multiplier.
void ResetGetHashErrors();
« no previous file with comments | « no previous file | components/safe_browsing_db/v4_get_hash_protocol_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698