fix #27672, call computeConstantValue for metadata

fix #27672, call computeConstantValue for metadata

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/bdeb6023afc02c15e6a660823c3308c977022c26

[Jennifer Messerly, 2016-10-27 20:15:13]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-10-27 20:58:20]

lgtm

We do call constantValue elsewhere - should we be calling this function there as
well in case it's coming from a summary?

[Jennifer Messerly, 2016-10-27 21:04:36]

On 2016/10/27 20:58:20, vsm wrote:
> lgtm
> 
> We do call constantValue elsewhere - should we be calling this function there
as
> well in case it's coming from a summary?

chatted about this, but there are 4 total places we use `.constantValue`. Only
one is for metadata, that I could tell. The other 3 are: right shift
optimization, nullability optimization, side-effect on field initializer
optimization. They're for ASTs we're compiling so should be safe to use
".constantValue".

[vsm, 2016-10-27 21:05:12]

On 2016/10/27 21:04:36, Jennifer Messerly wrote:
> On 2016/10/27 20:58:20, vsm wrote:
> > lgtm
> > 
> > We do call constantValue elsewhere - should we be calling this function
there
> as
> > well in case it's coming from a summary?
> 
> chatted about this, but there are 4 total places we use `.constantValue`. Only
> one is for metadata, that I could tell. The other 3 are: right shift
> optimization, nullability optimization, side-effect on field initializer
> optimization. They're for ASTs we're compiling so should be safe to use
> ".constantValue".

lgtm :-)

[Jennifer Messerly, 2016-10-27 21:06:00]

Description was changed from

==========
fix #27672, call computeConstantValue for metadata
==========

to

==========
fix #27672, call computeConstantValue for metadata

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/bdeb6023afc02c15e6a660823c33...
==========

[Jennifer Messerly, 2016-10-27 21:06:02]

Committed patchset #1 (id:1) manually as
bdeb6023afc02c15e6a660823c3308c977022c26 (presubmit successful).