Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: components/policy/core/common/cloud/device_management_service_unittest.cc

Issue 2458653003: Add "critical" parameter to DMServer requests. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/policy/core/common/cloud/device_management_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/policy/core/common/cloud/device_management_service_unittest.cc
diff --git a/components/policy/core/common/cloud/device_management_service_unittest.cc b/components/policy/core/common/cloud/device_management_service_unittest.cc
index 5a0bb4e9360f3da7863af118f591980388ac51d0..64cf4aa5ebdeb156bb68e2f6c83b69cea127c083 100644
--- a/components/policy/core/common/cloud/device_management_service_unittest.cc
+++ b/components/policy/core/common/cloud/device_management_service_unittest.cc
@@ -153,6 +153,23 @@ class DeviceManagementServiceTestBase : public testing::Test {
return job;
}
+ DeviceManagementRequestJob* StartCriticalPolicyFetchJob() {
+ DeviceManagementRequestJob* job = service_->CreateJob(
+ DeviceManagementRequestJob::TYPE_POLICY_FETCH, request_context_.get());
+ job->SetGaiaToken(kGaiaAuthToken);
+ job->SetOAuthToken(kOAuthToken);
+ job->SetClientID(kClientID);
+ job->SetCritical(true);
+ em::PolicyFetchRequest* fetch_request =
+ job->GetRequest()->mutable_policy_request()->add_request();
+ fetch_request->set_policy_type(dm_protocol::kChromeUserPolicyType);
+ job->SetRetryCallback(base::Bind(
+ &DeviceManagementServiceTestBase::OnJobRetry, base::Unretained(this)));
+ job->Start(base::Bind(&DeviceManagementServiceTestBase::OnJobDone,
+ base::Unretained(this)));
+ return job;
+ }
+
DeviceManagementRequestJob* StartAutoEnrollmentJob() {
DeviceManagementRequestJob* job =
service_->CreateJob(DeviceManagementRequestJob::TYPE_AUTO_ENROLLMENT,
@@ -403,7 +420,8 @@ class DeviceManagementServiceTest
void CheckURLAndQueryParams(const GURL& request_url,
const std::string& request_type,
const std::string& device_id,
- const std::string& last_error) {
+ const std::string& last_error,
+ bool critical = false) {
const GURL service_url(kServiceUrl);
EXPECT_EQ(service_url.scheme(), request_url.scheme());
EXPECT_EQ(service_url.host(), request_url.host());
@@ -417,6 +435,8 @@ class DeviceManagementServiceTest
dm_protocol::kValueDeviceType));
EXPECT_TRUE(query_params.Check(dm_protocol::kParamAppType,
dm_protocol::kValueAppType));
+ EXPECT_EQ(critical,
+ query_params.Check(dm_protocol::kParamCritical, "true"));
if (last_error == "") {
EXPECT_TRUE(query_params.Check(dm_protocol::kParamRetry, "false"));
} else {
@@ -459,6 +479,16 @@ TEST_F(DeviceManagementServiceTest, RegisterRequest) {
SendResponse(fetcher, net::OK, 200, response_data);
}
+TEST_F(DeviceManagementServiceTest, CriticalRequest) {
+ std::unique_ptr<DeviceManagementRequestJob> request_job(
+ StartCriticalPolicyFetchJob());
+ net::TestURLFetcher* fetcher = GetFetcher();
+ ASSERT_TRUE(fetcher);
+
+ CheckURLAndQueryParams(fetcher->GetOriginalURL(),
+ dm_protocol::kValueRequestPolicy, kClientID, "", true);
+}
+
TEST_F(DeviceManagementServiceTest, CertBasedRegisterRequest) {
em::DeviceManagementResponse expected_response;
expected_response.mutable_register_response()->
« no previous file with comments | « components/policy/core/common/cloud/device_management_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698