[turbofan] Handle inlining of API getters/setters.

[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call to the CallApiCallbackStub.

BUG=

Committed: https://crrev.com/88366741fc8ddfa6e9c1bd5d568a675cb64aa996
Cr-Commit-Position: refs/heads/master@{#40664}

[epertoso, 2016-10-27 08:45:49]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 08:45:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 08:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 08:59:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[epertoso, 2016-10-28 14:02:21]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 14:02:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 14:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 14:25:15]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-10-31 09:16:53]

Description was changed from

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=
==========

to

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=
==========

[epertoso, 2016-10-31 09:16:53]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-10-31 09:33:14]

LGTM with nits.

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:880:
CHECK(access_info.constant()->IsFunctionTemplateInfo());
Nit: DCHECK

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:883:
CHECK(!function_template_info->call_code()->IsUndefined(isolate()));
Nit: DCHECK

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:917:
CHECK(access_info.constant()->IsFunctionTemplateInfo());
Nit: DCHECK

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:920:
CHECK(!function_template_info->call_code()->IsUndefined(isolate()));
Nit: DCHECK

[epertoso, 2016-10-31 09:44:13]

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
File src/compiler/js-native-context-specialization.cc (right):

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:880:
CHECK(access_info.constant()->IsFunctionTemplateInfo());
On 2016/10/31 09:33:13, Benedikt Meurer wrote:
> Nit: DCHECK

Done.

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:883:
CHECK(!function_template_info->call_code()->IsUndefined(isolate()));
On 2016/10/31 09:33:13, Benedikt Meurer wrote:
> Nit: DCHECK

Done.

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:917:
CHECK(access_info.constant()->IsFunctionTemplateInfo());
On 2016/10/31 09:33:13, Benedikt Meurer wrote:
> Nit: DCHECK

Done.

https://codereview.chromium.org/2458643002/diff/20001/src/compiler/js-native-...
src/compiler/js-native-context-specialization.cc:920:
CHECK(!function_template_info->call_code()->IsUndefined(isolate()));
On 2016/10/31 09:33:13, Benedikt Meurer wrote:
> Nit: DCHECK

Done.

[epertoso, 2016-10-31 09:44:21]

The CQ bit was checked by epertoso@chromium.org

[epertoso, 2016-10-31 09:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2458643002/#ps40001
(title: "Update.")

[commit-bot: I haz the power, 2016-10-31 09:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 10:09:51]

Description was changed from

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=
==========

to

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=
==========

[commit-bot: I haz the power, 2016-10-31 10:09:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:17:44]

Description was changed from

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=
==========

to

==========
[turbofan] Handle inlining of API getters/setters.

Similar to what crankshaft does, we introduce a mapcheck if necessary and a call
to the CallApiCallbackStub.

BUG=

Committed: https://crrev.com/88366741fc8ddfa6e9c1bd5d568a675cb64aa996
Cr-Commit-Position: refs/heads/master@{#40664}
==========

[commit-bot: I haz the power, 2016-11-17 22:17:45]

Patchset 3 (id:??) landed as
https://crrev.com/88366741fc8ddfa6e9c1bd5d568a675cb64aa996
Cr-Commit-Position: refs/heads/master@{#40664}