Fix text color of WrenchMenu buttons on Linux Aura.

ui/views/view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #define _USE_MATH_DEFINES // For VC++ to get M_PI. This has to be first.
 
 #include "ui/views/view.h"
 
 #include <algorithm>
 #include <cmath>
@@ skipping 191 matching lines @@
   AddChildViewAt(view, child_count());
 }
 
 void View::AddChildViewAt(View* view, int index) {
   CHECK_NE(view, this) << "You cannot add a view as its own child";
   DCHECK_GE(index, 0);
   DCHECK_LE(index, child_count());
 
   // If |view| has a parent, remove it from its parent.
   View* parent = view->parent_;
-  const ui::NativeTheme* old_theme = view->GetNativeTheme();
+  ui::NativeTheme* old_theme = NULL;

[Evan Stade, 2014/04/22 00:25:41]

this change makes it so that OnNativeThemeChanged is called at least once for
each view

[sky, 2014/04/22 15:30:21]

Why do you need to do these changes?

[Evan Stade, 2014/04/22 17:12:32]

The changes on L239-241 just seem more correct to me.

For L212-214, on Chromeos, OnNativeThemeChanged never gets called for the wrench
menu because old_theme == new_theme even when it's first added to the hierarchy.

   if (parent) {
+    old_theme = view->GetNativeTheme();
     if (parent == this) {
       ReorderChildView(view, index);
       return;
     }
     parent->DoRemoveChildView(view, true, true, false, this);
   }
 
   // Sets the prev/next focus views.
   InitFocusSiblings(view, index);
 
   // Let's insert the view.
   view->parent_ = this;
   children_.insert(children_.begin() + index, view);
 
   ViewHierarchyChangedDetails details(true, this, view, parent);
 
   for (View* v = this; v; v = v->parent_)
     v->ViewHierarchyChangedImpl(false, details);
 
   view->PropagateAddNotifications(details);
   UpdateTooltip();
   views::Widget* widget = GetWidget();
   if (widget) {
     RegisterChildrenForVisibleBoundsNotification(view);
-    const ui::NativeTheme* new_theme = widget->GetNativeTheme();
+    const ui::NativeTheme* new_theme = view->GetNativeTheme();
     if (new_theme != old_theme)
-      PropagateNativeThemeChanged(new_theme);
+      view->PropagateNativeThemeChanged(new_theme);
     if (view->visible())
       view->SchedulePaint();
   }
 
   if (layout_manager_.get())
     layout_manager_->ViewAdded(this, view);
 
   ReorderLayers();
 
   // Make sure the visibility of the child layers are correct.
@@ skipping 2103 matching lines @@
   // Message the RootView to do the drag and drop. That way if we're removed
   // the RootView can detect it and avoid calling us back.
   gfx::Point widget_location(event.location());
   ConvertPointToWidget(this, &widget_location);
   widget->RunShellDrag(this, data, widget_location, drag_operations, source);
   // WARNING: we may have been deleted.
   return true;
 }
 
 }  // namespace views