Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2458623002: [turbofan] Relax a too-strict dcheck. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, ahaas
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Relax a too-strict dcheck. BUG=v8:5573 Committed: https://crrev.com/21d55e2166d1a909300e61e4e9c9bed6ff0bb7a7 Cr-Commit-Position: refs/heads/master@{#40619}

Patch Set 1 #

Patch Set 2 : Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-v8-5573.js View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-10-27 11:43:54 UTC) #8
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-10-27 12:30:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458623002/20001
4 years, 1 month ago (2016-10-27 12:30:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 12:32:43 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21d55e2166d1a909300e61e4e9c9bed6ff0bb7a7
Cr-Commit-Position: refs/heads/master@{#40619}

Powered by Google App Engine
This is Rietveld 408576698