Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h

Issue 2458613004: Record the initial state of the Physical Web at startup (Closed)
Patch Set: move reporting to IOSChromePhysicalWebDataSource Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h
diff --git a/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h b/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h
similarity index 75%
rename from ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h
rename to ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h
index a21a2a6b7cf9a4ab8060fc6c8c200f0668ef2046..aec5ed7f0ab6e636ccd9ef025d5752e674079054 100644
--- a/ios/chrome/common/physical_web/ios_chrome_physical_web_data_source.h
+++ b/ios/chrome/browser/physical_web/ios_chrome_physical_web_data_source.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IOS_CHROME_COMMON_PHYSICAL_WEB_IOS_CHROME_PHYSICAL_WEB_DATA_SOURCE_H_
-#define IOS_CHROME_COMMON_PHYSICAL_WEB_IOS_CHROME_PHYSICAL_WEB_DATA_SOURCE_H_
+#ifndef IOS_CHROME_BROWSER_PHYSICAL_WEB_IOS_CHROME_PHYSICAL_WEB_DATA_SOURCE_H_
+#define IOS_CHROME_BROWSER_PHYSICAL_WEB_IOS_CHROME_PHYSICAL_WEB_DATA_SOURCE_H_
mattreynolds 2016/11/04 00:28:53 The data source implementation shouldn't be in ios
#include "base/macros.h"
#import "base/mac/scoped_nsobject.h"
@@ -13,8 +13,10 @@ namespace base {
class ListValue;
}
class PhysicalWebListener;
+class PrefService;
@class PhysicalWebScanner;
+@class PhysicalWebInitialStateRecorder;
// iOS implementation of PhysicalWebDataSource
class IOSChromePhysicalWebDataSource : public PhysicalWebDataSourceImpl {
@@ -37,10 +39,16 @@ class IOSChromePhysicalWebDataSource : public PhysicalWebDataSourceImpl {
// or more discovered URLs that have not been sent to the resolution service.
bool HasUnresolvedDiscoveries() override;
+ // Records the initial state of settings relevant to the Physical Web feature.
+ void RecordInitialState(PrefService* prefService);
+
private:
// Scanner for nearby Physical Web URL devices.
base::scoped_nsobject<PhysicalWebScanner> scanner_;
+ // Utility for fetching initial application state for logging purposes.
+ base::scoped_nsobject<PhysicalWebInitialStateRecorder> initialStateRecorder_;
+
DISALLOW_COPY_AND_ASSIGN(IOSChromePhysicalWebDataSource);
};

Powered by Google App Engine
This is Rietveld 408576698