Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: media/cast/cast_thread.cc

Issue 24586003: Be able to build cast_unittest and related targets in Chrome tree (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix warnings Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/cast_thread.cc
diff --git a/media/cast/cast_thread.cc b/media/cast/cast_thread.cc
index 4d294c4656840fbb76973a3ba4b6d6018976989e..5b59a65053202b990246cde911ac5fb1e1fae353 100644
--- a/media/cast/cast_thread.cc
+++ b/media/cast/cast_thread.cc
@@ -25,6 +25,9 @@ CastThread::CastThread(
DCHECK(main_thread_proxy) << "Main thread required";
}
+CastThread::~CastThread() {
pwestin 2013/09/26 23:20:23 nit: {} on same line
Alpha Left Google 2013/09/27 00:45:13 Done.
+}
+
bool CastThread::PostTask(ThreadId identifier,
const tracked_objects::Location& from_here,
const base::Closure& task) {
@@ -57,6 +60,9 @@ scoped_refptr<TaskRunner> CastThread::GetMessageTaskRunnerForThread(
return video_encode_thread_proxy_;
case CastThread::VIDEO_DECODER:
return video_decode_thread_proxy_;
+ default:
+ CHECK(false) << "Invalid Thread ID.";
+ return NULL;
pwestin 2013/09/26 23:20:23 Why add this? it's much better to get a compilatio
Alpha Left Google 2013/09/27 00:45:13 VC++ complains without this case.
}
}

Powered by Google App Engine
This is Rietveld 408576698