media/cast/rtcp/test_rtcp_packet_builder.h - Issue 24586003: Be able to build cast_unittest and related targets in Chrome tree

Side by Side Diff: media/cast/rtcp/test_rtcp_packet_builder.h

Issue 24586003: Be able to build cast_unittest and related targets in Chrome tree (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix warnings Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« media/cast/cast_thread.cc ('K') | « media/cast/rtcp/rtcp_unittest.cc ('k') | media/cast/rtp_common/mock_rtp_payload_feedback.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // A very simple packet builder class for building RTCP packets.	5 // A very simple packet builder class for building RTCP packets.

6 // Used for testing only.	6 // Used for testing only.

7 #ifndef MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_	7 #ifndef MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_

8 #define MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_	8 #define MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_

9	9

10 #include "media/cast/rtcp/rtcp_defines.h"	10 #include "media/cast/rtcp/rtcp_defines.h"

(...skipping 14 matching lines...) Expand all Loading...
25 static const int kExtendedMax = 0x15678;	25 static const int kExtendedMax = 0x15678;

26 static const int kJitter = 0x10203;	26 static const int kJitter = 0x10203;

27 static const int kLastSr = 0x34561234;	27 static const int kLastSr = 0x34561234;

28 static const int kDelayLastSr = 1000;	28 static const int kDelayLastSr = 1000;

29	29

30 // DLRR block.	30 // DLRR block.

31 static const int kLastRr = 0x34561234;	31 static const int kLastRr = 0x34561234;

32 static const int kDelayLastRr = 1000;	32 static const int kDelayLastRr = 1000;

33	33

34 // REMB.	34 // REMB.

35 static const int kRembBitrate = 524286;	35 static const int kRembBitrate = 52428;
	hubbe 2013/09/26 23:03:20 ? ? Alpha Left Google 2013/09/27 00:45:13 This value is chosen randomly for testing. It can Show quoted text On 2013/09/26 23:03:20, hubbe wrote: > ? This value is chosen randomly for testing. It can be of any value. Compiler complains because this const value get assigned to a uint16. hubbe 2013/09/27 19:22:53 Add a comment that the value is arbitrary perhaps? Show quoted text On 2013/09/27 00:45:13, Alpha wrote: > On 2013/09/26 23:03:20, hubbe wrote: > > ? > > This value is chosen randomly for testing. It can be of any value. Compiler > complains because this const value get assigned to a uint16. Add a comment that the value is arbitrary perhaps? Alpha Left Google 2013/09/27 21:13:53 Done. Show quoted text On 2013/09/27 19:22:53, hubbe wrote: > On 2013/09/27 00:45:13, Alpha wrote: > > On 2013/09/26 23:03:20, hubbe wrote: > > > ? > > > > This value is chosen randomly for testing. It can be of any value. Compiler > > complains because this const value get assigned to a uint16. > > Add a comment that the value is arbitrary perhaps? Done.
36	36

37 // RPSI.	37 // RPSI.

38 static const int kPayloadtype = 126;	38 static const int kPayloadtype = 126;

39 static const uint64 kPictureId = 0x1234567890;	39 static const uint64 kPictureId = 0x1234567890;

40	40

41 // NACK.	41 // NACK.

42 static const int kMissingPacket = 34567;	42 static const int kMissingPacket = 34567;

43	43

44 // CAST.	44 // CAST.

45 static const int kAckFrameId = 17;	45 static const int kAckFrameId = 17;

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83 // Note: 0 is not a legal value, it is used for "uninitialized".	83 // Note: 0 is not a legal value, it is used for "uninitialized".

84 uint8 buffer_[kIpPacketSize];	84 uint8 buffer_[kIpPacketSize];

85 char* ptr_of_length_;	85 char* ptr_of_length_;

86 net::BigEndianWriter big_endian_writer_;	86 net::BigEndianWriter big_endian_writer_;

87 };	87 };

88	88

89 } // namespace cast	89 } // namespace cast

90 } // namespace media	90 } // namespace media

91	91

92 #endif // MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_	92 #endif // MEDIA_CAST_RTCP_TEST_RTCP_PACKET_BUILDER_H_

93

94

OLD	NEW