third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp - Issue 2458573002: bindings: Store ScriptState in generated callback functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

diff --git a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

index b2c876f85b8eaea75e4172a3abaeacc905d3badc..2ea1b664788ccbc49b6f1201a02c665833156a4e 100644

--- a/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

+++ b/third_party/WebKit/Source/core/timing/PerformanceBaseTest.cpp

@@ -38,8 +38,7 @@ class PerformanceBaseTest : public ::testing::Test {

v8::Local<v8::Function> callback =

v8::Function::New(scriptState->context(), nullptr).ToLocalChecked();

m_base = new TestPerformanceBase();

- m_cb =

- PerformanceObserverCallback::create(scriptState->isolate(), callback);

+ m_cb = PerformanceObserverCallback::create(scriptState, callback);

m_observer = PerformanceObserver::create(scriptState, m_base, m_cb);

}