Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
index 295eae25f511a69d7c47dbac97522d93f01726f8..7e96f48717f3077619c592d56e1cd44cac196ce5 100644
--- a/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
+++ b/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h
@@ -22,9 +22,9 @@ class ScriptState;
class MODULES_EXPORT VoidCallbackFunctionModules final : public GarbageCollectedFinalized<VoidCallbackFunctionModules>,
public TraceWrapperBase {
public:
- static VoidCallbackFunctionModules* create(v8::Isolate* isolate, v8::Local<v8::Function> callback)
+ static VoidCallbackFunctionModules* create(ScriptState* scriptState, v8::Local<v8::Function> callback)
{
- return new VoidCallbackFunctionModules(isolate, callback);
+ return new VoidCallbackFunctionModules(scriptState, callback);
}
~VoidCallbackFunctionModules() = default;
@@ -32,7 +32,7 @@ public:
DECLARE_TRACE();
DECLARE_TRACE_WRAPPERS();
- bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable);
+ bool call(ScriptWrappable* scriptWrappable);
v8::Local<v8::Function> v8Value(v8::Isolate* isolate)
{
@@ -46,7 +46,9 @@ public:
}
private:
- VoidCallbackFunctionModules(v8::Isolate* isolate, v8::Local<v8::Function>);
+ VoidCallbackFunctionModules(ScriptState*, v8::Local<v8::Function>);
+
+ RefPtr<ScriptState> m_scriptState;
ScopedPersistent<v8::Function> m_callback;
};

Powered by Google App Engine
This is Rietveld 408576698