Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
index 63b10a8c44c14253bd818b7b04b887265ae65a8d..d5c5ee8aaa868c6e616d14c6fd966529a3cf00e1 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_callback_function.py
@@ -51,7 +51,8 @@ def callback_function_context(callback_function):
'return_value': idl_type.v8_value_to_local_cpp_value(
callback_function.extended_attributes,
'v8ReturnValue', 'cppValue',
- isolate='scriptState->isolate()', bailout_return_value='false'),
+ isolate='m_scriptState->isolate()',
+ bailout_return_value='false'),
})
context.update(arguments_context(callback_function.arguments, context.get('return_cpp_type')))
@@ -63,12 +64,11 @@ def arguments_context(arguments, return_cpp_type):
return {
'argument_name': '%sArgument' % argument.name,
'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
- argument.name, isolate='scriptState->isolate()',
- creation_context='scriptState->context()->Global()'),
+ argument.name, isolate='m_scriptState->isolate()',
+ creation_context='m_scriptState->context()->Global()'),
}
argument_declarations = [
- 'ScriptState* scriptState',
'ScriptWrappable* scriptWrappable',
]
argument_declarations.extend(

Powered by Google App Engine
This is Rietveld 408576698