Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp

Issue 2458573002: bindings: Store ScriptState in generated callback functions (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
index b1ed580cbff085afa7ab3ca495dd57ec72319cba..11d65aafbdcbe4a66acf0ca522ec966feed79bbc 100644
--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8PerformanceObserverCustom.cpp
@@ -49,12 +49,13 @@ void V8PerformanceObserver::constructorCustom(
"The callback provided as parameter 1 is not a function."));
return;
}
+ ScriptState* scriptState = ScriptState::forReceiverObject(info);
v8::Local<v8::Function> v8Callback = v8::Local<v8::Function>::Cast(info[0]);
PerformanceObserverCallback* callback =
- PerformanceObserverCallback::create(info.GetIsolate(), v8Callback);
+ PerformanceObserverCallback::create(scriptState, v8Callback);
- PerformanceObserver* observer = PerformanceObserver::create(
- ScriptState::forReceiverObject(info), performance, callback);
+ PerformanceObserver* observer =
+ PerformanceObserver::create(scriptState, performance, callback);
// TODO(bashi): Don't set private property (and remove this custom
// constructor) when we can call setWrapperReference() correctly.
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698