Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2458563002: Reland of [devil] Roll to ADB 1.0.36. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Reland of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2439243002/ ) Reason for revert: Worked around adb forward --list separately. Original issue's description: > Revert of [devil] Roll to ADB 1.0.36. (patchset #1 id:1 of https://codereview.chromium.org/2436373002/ ) > > Reason for revert: > protocol faults on AN5XSR > > Original issue's description: > > [devil] Roll to ADB 1.0.36. > > > > BUG=chromium:623989 > > > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/49501c0da3481155637169304dfc4a7079bed6fa > > TBR=stip@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:623989 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d51bcdede9c4a051841a087f1a7fbc52ab9adf11 TBR=stip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:623989 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/3cf97ee42867b800d8d3a7f33464e62ec11ec4f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M devil/devil/devil_dependencies.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jbudorick
Created Reland of [devil] Roll to ADB 1.0.36.
4 years, 1 month ago (2016-10-27 00:37:36 UTC) #1
jbudorick
PTAL. No changes since the original landing.
4 years, 1 month ago (2016-10-27 00:38:03 UTC) #2
ghost stip (do not use)
lgtm
4 years, 1 month ago (2016-10-28 18:40:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458563002/1
4 years, 1 month ago (2016-10-31 17:24:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/3cf97ee42867b800d8d3a7f33464e62ec11ec4f0
4 years, 1 month ago (2016-10-31 17:44:58 UTC) #7
jbudorick
4 years, 1 month ago (2016-11-01 19:15:33 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2464173002/ by jbudorick@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=661233.

Powered by Google App Engine
This is Rietveld 408576698