Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2458513004: Revert of Remove supports_touch_events flag from BasicDesktopEnvironment (Closed)

Created:
4 years, 1 month ago by foolip
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Hzj_jie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove supports_touch_events flag from BasicDesktopEnvironment (patchset #2 id:20001 of https://codereview.chromium.org/2456563002/ ) Reason for revert: IpcDesktopEnvironmentTest.CapabilitiesNoTouch failing on Win10 Tests x64 BUG=659927 Original issue's description: > Remove supports_touch_events flag from BasicDesktopEnvironment > > supports_touch_events flag was always enabled on platforms that support > it, so it's not necessary to put it in BasicDesktopEnvironment. > > Committed: https://crrev.com/9d73a960dbf02b4d834532d07b2e9553b795f60c > Cr-Commit-Position: refs/heads/master@{#427858} TBR=zijiehe@chromium.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2 Cr-Commit-Position: refs/heads/master@{#427962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -52 lines) Patch
M remoting/host/basic_desktop_environment.h View 5 chunks +15 lines, -1 line 0 comments Download
M remoting/host/basic_desktop_environment.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M remoting/host/desktop_session_proxy.h View 2 chunks +5 lines, -1 line 0 comments Download
M remoting/host/desktop_session_proxy.cc View 3 chunks +9 lines, -11 lines 0 comments Download
M remoting/host/ipc_desktop_environment.h View 3 chunks +11 lines, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M remoting/host/it2me_desktop_environment.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/it2me_desktop_environment.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/me2me_desktop_environment.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/me2me_desktop_environment.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/single_window_desktop_environment.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M remoting/host/win/session_desktop_environment.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/win/session_desktop_environment.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
foolip
Created Revert of Remove supports_touch_events flag from BasicDesktopEnvironment
4 years, 1 month ago (2016-10-27 08:38:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458513004/1
4 years, 1 month ago (2016-10-27 08:39:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 08:40:11 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 08:42:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd0b383452ce174be4f63b6c7e46b8e5180644e2
Cr-Commit-Position: refs/heads/master@{#427962}

Powered by Google App Engine
This is Rietveld 408576698