Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2458503004: android: Keep the context on disconnect in GSAServiceClient. (Closed)

Created:
4 years, 1 month ago by Benoit L
Modified:
4 years, 1 month ago
Reviewers:
Bernhard Bauer, Yusuf, gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Keep the context on disconnect in GSAServiceClient. This fixes a crash, since now the same GSAServiceClient can be used several times in a row. BUG=659989 Committed: https://crrev.com/1254a5289eba87f35daa4f2e69af7eaa6c198490 Cr-Commit-Position: refs/heads/master@{#428134}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java View 2 chunks +1 line, -3 lines 1 comment Download

Messages

Total messages: 16 (8 generated)
Benoit L
4 years, 1 month ago (2016-10-27 18:51:19 UTC) #2
Yusuf
lgtm
4 years, 1 month ago (2016-10-27 18:54:22 UTC) #5
Benoit L
On 2016/10/27 18:54:22, Yusuf wrote: > lgtm @dfalcantara: Please send this to the CQ if ...
4 years, 1 month ago (2016-10-27 19:01:42 UTC) #6
gone
lgtm
4 years, 1 month ago (2016-10-27 20:55:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458503004/1
4 years, 1 month ago (2016-10-27 20:56:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 21:06:27 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1254a5289eba87f35daa4f2e69af7eaa6c198490 Cr-Commit-Position: refs/heads/master@{#428134}
4 years, 1 month ago (2016-10-27 21:09:30 UTC) #14
Bernhard Bauer
4 years, 1 month ago (2016-10-28 08:49:19 UTC) #16
Message was sent while issue was closed.
https://codereview.chromium.org/2458503004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java
(right):

https://codereview.chromium.org/2458503004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java:88:
mGsaHelper = ((ChromeApplication) mContext.getApplicationContext())
Nit: You already have the application context :)

Powered by Google App Engine
This is Rietveld 408576698