Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.
Patch Set: rebase + blink reformat Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index da9e4f1471ddf000dbf74c01c44ad6460328c238..05b30f522a926a73e84d6500d1cbff91bfda21fa 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -519,6 +519,10 @@ void PermissionUmaUtil::PermissionPromptAcceptedWithPersistenceToggle(
UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Accepted.Persisted.Flash",
toggle_enabled);
break;
+
+ case CONTENT_SETTINGS_TYPE_SENSORS:
+ // TODO(riju): when UMA is ready.
+ break;
// The user is not prompted for these permissions, thus there is no accept
// recorded for them.
default:
@@ -568,6 +572,9 @@ void PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle(
UMA_HISTOGRAM_BOOLEAN("Permissions.Prompt.Denied.Persisted.Flash",
toggle_enabled);
break;
+ case CONTENT_SETTINGS_TYPE_SENSORS:
+ // TODO(riju): when UMA is ready.
+ break;
// The user is not prompted for these permissions, thus there is no deny
// recorded for them.
default:
@@ -656,6 +663,15 @@ void PermissionUmaUtil::RecordPermissionAction(
UMA_HISTOGRAM_ENUMERATION("Permissions.Action.MidiSysEx", action,
PermissionAction::NUM);
break;
+ // TODO(riju) : when UMA is ready.
+ case CONTENT_SETTINGS_TYPE_SENSORS:
+ /*
+ PERMISSION_ACTION_UMA(secure_origin, "Permissions.Action.Sensors",
+ "Permissions.Action.SecureOrigin.Sensors",
+ "Permissions.Action.InsecureOrigin.Sensors",
+ action);
+ */
+ break;
case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:
UMA_HISTOGRAM_ENUMERATION("Permissions.Action.PushMessaging", action,
PermissionAction::NUM);
« no previous file with comments | « chrome/browser/permissions/permission_request_impl.cc ('k') | chrome/browser/permissions/permission_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698