third_party/WebKit/Source/modules/sensor/Sensor.cpp - Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.cpp

Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.

Patch Set: Request for permission, in onSensorCreated() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/Sensor.cpp

diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.cpp b/third_party/WebKit/Source/modules/sensor/Sensor.cpp

index 60551e7edd45e22c1090aaf8f1f05beec2d6fa4a..cc5967b8c929be5141a3496d2514725b75bf4539 100644

--- a/third_party/WebKit/Source/modules/sensor/Sensor.cpp

+++ b/third_party/WebKit/Source/modules/sensor/Sensor.cpp

@@ -167,8 +167,10 @@ void Sensor::initSensorProxyIfNeeded() {

m_sensorProxy = provider->getSensor(m_type);

if (!m_sensorProxy) {

- m_sensorProxy =

- provider->createSensor(m_type, createSensorReadingFactory());

+ RefPtr<SecurityOrigin> origin = getExecutionContext()->getSecurityOrigin();

+ DCHECK(origin);

+ m_sensorProxy = provider->createSensor(m_type, std::move(origin),

+ createSensorReadingFactory());

}