chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java - Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.

Patch Set: Move permissions stuff to SensorProxy, remove aw related stuff Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_contents.h ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SensorInfo.java » ('j') | third_party/WebKit/Source/modules/sensor/Sensor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

index a110e3020b4032e0b060a4a38cff32d2cc80a317..fac8f5e4b96eda1198941122c84af1a1c49c4c59 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java

@@ -138,6 +138,10 @@ public class ContentSettingsResources {

localMap.put(ContentSettingsType.CONTENT_SETTINGS_TYPE_MIDI_SYSEX,

new ResourceItem(R.drawable.permission_midi, 0,

R.string.midi_sysex_permission_title, null, null, 0, 0));

+ // TODO(riju) : fix it (use midi's resources now)

+ localMap.put(ContentSettingsType.CONTENT_SETTINGS_TYPE_SENSORS,

+ new ResourceItem(R.drawable.permission_midi, 0,

+ R.string.sensors_permission_title, null, null, 0, 0));

localMap.put(ContentSettingsType.CONTENT_SETTINGS_TYPE_NOTIFICATIONS,

new ResourceItem(R.drawable.permission_push_notification,

R.string.push_notifications_permission_title,