Index: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp |
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp |
index e3b01f30c0d560100a8eb40e5720b98fa23a2870..b7ccea2e13e7d412e79dcbac02b8c6141fbd9abd 100644 |
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp |
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp |
@@ -5,16 +5,25 @@ |
#include "modules/sensor/SensorProxy.h" |
#include "core/frame/LocalFrame.h" |
+#include "modules/permissions/PermissionUtils.h" |
#include "modules/sensor/SensorProviderProxy.h" |
#include "modules/sensor/SensorReading.h" |
+#include "platform/UserGestureIndicator.h" |
#include "platform/mojo/MojoHelper.h" |
+#include "platform/weborigin/SecurityOrigin.h" |
#include "public/platform/Platform.h" |
using namespace device::mojom::blink; |
namespace blink { |
+using mojom::blink::PermissionName; |
+using mojom::blink::PermissionService; |
+using mojom::blink::PermissionStatus; |
+ |
SensorProxy::SensorProxy(SensorType sensorType, |
+ PermissionService* permissionService, |
+ RefPtr<SecurityOrigin> origin, |
SensorProviderProxy* provider, |
std::unique_ptr<SensorReadingFactory> readingFactory) |
: m_type(sensorType), |
@@ -24,7 +33,29 @@ SensorProxy::SensorProxy(SensorType sensorType, |
m_state(SensorProxy::Uninitialized), |
m_suspended(false), |
m_readingFactory(std::move(readingFactory)), |
- m_maximumFrequency(0.0) {} |
+ m_maximumFrequency(0.0), |
+ m_permissionStatus(PermissionStatus::ASK), |
+ m_permissionService(permissionService), |
+ m_securityOrigin(std::move(origin)) {} |
+ |
+void SensorProxy::onPermissionUpdate(PermissionStatus status) { |
+ if (m_permissionStatus != status) { |
+ m_permissionStatus = status; |
+ if (!isInitialized()) |
Mikhail
2016/11/18 12:37:43
so, any external permission changes could initiate
riju_
2016/11/21 11:23:28
Acknowledged.
|
+ initialize(); |
+ } |
+ |
+ // If permission is revoked, throw error. |
+ if (m_permissionStatus != PermissionStatus::GRANTED) |
+ handleSensorError(NotAllowedError, "Permission not granted."); |
Mikhail
2016/11/18 12:37:42
what it if we in the middle of initialization, or
riju_
2016/11/21 11:23:28
Acknowledged.
|
+ |
+ // Keep listening to changes. |
+ m_permissionService->GetNextPermissionChange( |
+ createPermissionDescriptor(PermissionName::SENSORS), m_securityOrigin, |
+ m_permissionStatus, |
+ convertToBaseCallback(WTF::bind(&SensorProxy::onPermissionUpdate, |
+ wrapWeakPersistent(this)))); |
+} |
SensorProxy::~SensorProxy() {} |
@@ -56,11 +87,29 @@ void SensorProxy::initialize() { |
return; |
} |
- m_state = Initializing; |
auto callback = convertToBaseCallback( |
WTF::bind(&SensorProxy::onSensorCreated, wrapWeakPersistent(this))); |
- m_provider->sensorProvider()->GetSensor(m_type, mojo::GetProxy(&m_sensor), |
- callback); |
+ |
+ switch (m_permissionStatus) { |
+ case PermissionStatus::ASK: |
+ // Request permission. |
+ m_permissionService->RequestPermission( |
+ createPermissionDescriptor(PermissionName::SENSORS), m_securityOrigin, |
+ UserGestureIndicator::processingUserGesture(), |
+ convertToBaseCallback(WTF::bind(&SensorProxy::onPermissionUpdate, |
+ wrapPersistent(this)))); |
Mikhail
2016/11/18 12:37:43
why to hold proxy instance alive until onPermissio
riju_
2016/11/21 11:23:28
Done.
|
+ break; |
+ case PermissionStatus::DENIED: |
+ handleSensorError(NotAllowedError, "Permission not granted."); |
+ break; |
+ case PermissionStatus::GRANTED: |
+ m_state = Initializing; |
+ m_provider->sensorProvider()->GetSensor(m_type, mojo::GetProxy(&m_sensor), |
+ callback); |
+ break; |
+ default: |
+ NOTREACHED(); |
+ } |
} |
void SensorProxy::addConfiguration( |