Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.h

Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/Sensor.h
diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.h b/third_party/WebKit/Source/modules/sensor/Sensor.h
index e1aacf407cdb04730dc594e605b3498a1959e2bf..a1a09761d529970ae6bac4d72d928aa743c1ec9f 100644
--- a/third_party/WebKit/Source/modules/sensor/Sensor.h
+++ b/third_party/WebKit/Source/modules/sensor/Sensor.h
@@ -15,6 +15,8 @@
#include "modules/sensor/SensorOptions.h"
#include "modules/sensor/SensorProxy.h"
#include "platform/heap/Handle.h"
+#include "public/platform/modules/permissions/permission.mojom-blink.h"
+#include "public/platform/modules/permissions/permission_status.mojom-blink.h"
namespace blink {
@@ -110,6 +112,11 @@ class Sensor : public EventTargetWithInlineData,
void notifyStateChanged();
void notifyError(DOMException* error);
+ mojom::blink::PermissionService* getPermissionService(ExecutionContext*);
+ void permissionServiceConnectionError();
+ void onPermissionUpdate(ExecutionContext*, mojom::blink::PermissionStatus);
+ void requestPermission(ExecutionContext*, mojom::blink::PermissionStatus);
+
private:
Member<SensorReading> m_sensorReading;
SensorOptions m_sensorOptions;
@@ -119,6 +126,10 @@ class Sensor : public EventTargetWithInlineData,
std::unique_ptr<SensorPollingStrategy> m_polling;
SensorProxy::Reading m_storedData;
SensorConfigurationPtr m_configuration;
+
+ mojom::blink::PermissionStatus m_sensorPermission;
+
+ mojom::blink::PermissionServicePtr m_permissionService;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698