Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 2458453002: [sensors] Add Permission guard to the generic sensor apis.
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index edbd1cb28bfa5daa759b4ebd3aa02b2cf9dc8c1d..878cb7be3c471dbc3230f6336a4df67480c726d1 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -265,6 +265,14 @@ class TabSpecificContentSettings
return midi_usages_state_;
}
+ /*
+ // Returns the ContentSettingsUsageState that controls the Sensors usage on
+ // this page.
+ const ContentSettingsUsagesState& sensors_usages_state() const {
+ return sensors_usages_state_;
+ }
+ */
+
// Call to indicate that there is a protocol handler pending user approval.
void set_pending_protocol_handler(const ProtocolHandler& handler) {
pending_protocol_handler_ = handler;
@@ -373,6 +381,10 @@ class TabSpecificContentSettings
void OnMidiSysExAccessed(const GURL& reqesting_origin);
void OnMidiSysExAccessBlocked(const GURL& requesting_origin);
+ // There methods are called to update the status about Sensor access.
+ void OnSensorAccessed(const GURL& reqesting_origin);
+ void OnSensorAccessBlocked(const GURL& requesting_origin);
+
// Adds the given |SiteDataObserver|. The |observer| is notified when a
// locale shared object, like for example a cookie, is accessed.
void AddSiteDataObserver(SiteDataObserver* observer);
@@ -415,12 +427,20 @@ class TabSpecificContentSettings
// Clears the MIDI settings.
void ClearMidiContentSettings();
+ // TODO(riju): when UMA is ready.
+ // Clears the Sensor settings.
+ // void ClearSensorContentSettings();
+
// Updates Geolocation settings on navigation.
void GeolocationDidNavigate(content::NavigationHandle* navigation_handle);
// Updates MIDI settings on navigation.
void MidiDidNavigate(content::NavigationHandle* navigation_handle);
+ // TODO(riju): when UMA is ready.
+ // Updates Sensor settings on navigation.
+ // void SensorDidNavigate(content::NavigationHandle* navigation_handle);
+
// All currently registered |SiteDataObserver|s.
base::ObserverList<SiteDataObserver> observer_list_;
@@ -442,6 +462,9 @@ class TabSpecificContentSettings
// Manages information about MIDI usages in this page.
ContentSettingsUsagesState midi_usages_state_;
+ // Manages information about sensors usages in this page.
+ // ContentSettingsUsagesState sensors_usages_state_;
+
// The pending protocol handler, if any. This can be set if
// registerProtocolHandler was invoked without user gesture.
// The |IsEmpty| method will be true if no protocol handler is

Powered by Google App Engine
This is Rietveld 408576698