[sensors] Add Permission guard to the generic sensor apis.

third_party/WebKit/Source/modules/sensor/SensorProxy.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SensorProxy_h
 #define SensorProxy_h
 
 #include "core/dom/ExceptionCode.h"
+#include "core/dom/ExecutionContext.h"
 #include "device/generic_sensor/public/cpp/sensor_reading.h"
 #include "device/generic_sensor/public/interfaces/sensor.mojom-blink.h"
 #include "device/generic_sensor/public/interfaces/sensor_provider.mojom-blink.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "platform/Supplementable.h"
 #include "platform/heap/Handle.h"
+#include "public/platform/modules/permissions/permission.mojom-blink.h"
+#include "public/platform/modules/permissions/permission_status.mojom-blink.h"
 
 namespace blink {
 
 class SensorProviderProxy;
 class SensorReading;
 class SensorReadingFactory;
 
 // This class wraps 'Sensor' mojo interface and used by multiple
 // JS sensor instances of the same type (within a single frame).
 class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
                           public device::mojom::blink::SensorClient {
   USING_PRE_FINALIZER(SensorProxy, dispose);
   WTF_MAKE_NONCOPYABLE(SensorProxy);
 
  public:
   class Observer : public GarbageCollectedMixin {
    public:
     // Has valid 'Sensor' binding, {add, remove}Configuration()
     // methods can be called.
     virtual void onSensorInitialized() {}
     // Platfrom sensort reading has changed (for 'ONCHANGE' reporting mode).
     virtual void onSensorReadingChanged() {}
     // An error has occurred.
     virtual void onSensorError(ExceptionCode,
                                const String& sanitizedMessage,
                                const String& unsanitizedMessage) {}
+    // Permission for sensor has changed.
+    virtual void onSensorPermissionChanged() {}
   };
 
   ~SensorProxy();
 
   void dispose();
 
   void addObserver(Observer*);
   void removeObserver(Observer*);
 
   void initialize();
@@ skipping 15 matching lines @@
   // The |SensorReading| instance which is shared between sensor instances
   // of the same type.
   // Note: the returned value is reset after updateSensorReading() call.
   SensorReading* sensorReading() const { return m_reading; }
 
   const device::mojom::blink::SensorConfiguration* defaultConfig() const;
 
   // Updates sensor reading from shared buffer.
   void updateSensorReading();
 
+  mojom::blink::PermissionService* getPermissionService(ExecutionContext*);

[Mikhail, 2016/11/10 09:30:48]

1) permissionService()
2) why pass |ExecutionContext| there? doesn't proxy have it already?

[riju_, 2016/11/14 14:00:07]

Done.

+  void resetPermissionService();
+  void permissionServiceConnectionError();

[Mikhail, 2016/11/10 09:30:48]

name of this function looks like a getter, it's unclear what it's doing

[riju_, 2016/11/14 14:00:07]

Removing it.

+  void onPermissionUpdate(mojom::blink::PermissionStatus);

[Mikhail, 2016/11/10 09:30:48]

does it need to be public? (same comment allies to other introduces methods)

[riju_, 2016/11/14 14:00:07]

Done.

+  void getNextPermissionChange(ExecutionContext*,
+                               mojom::blink::PermissionStatus);
+  void requestPermission(ExecutionContext*, mojom::blink::PermissionStatus);
+  mojom::blink::PermissionStatus getPermissionStatus() const {

[Mikhail, 2016/11/10 09:30:48]

permissionStatus()

[riju_, 2016/11/14 14:00:07]

removing it.

+    return m_sensorPermission;
+  };
+  bool getStartPendingPermission() const { return m_startPendingPermission; }

[Mikhail, 2016/11/10 09:30:48]

bool pendingPermissionRequest() const ?

[riju_, 2016/11/14 14:00:07]

Not needed now. removing it.

+  void setStartPendingPermission(bool value) {
+    m_startPendingPermission = value;
+  }
+
   DECLARE_VIRTUAL_TRACE();
 
  private:
   friend class SensorProviderProxy;
   SensorProxy(device::mojom::blink::SensorType,
+              ExecutionContext*,
               SensorProviderProxy*,
               std::unique_ptr<SensorReadingFactory>);
 
   // device::mojom::blink::SensorClient overrides.
   void RaiseError() override;
   void SensorReadingChanged() override;
 
+  void SensorPermissionChanged();
+
   // Generic handler for a fatal error.
   // String parameters are intentionally copied.
   void handleSensorError(ExceptionCode = UnknownError,
                          String sanitizedMessage = String(),
                          String unsanitizedMessage = String());
 
   void onSensorCreated(device::mojom::blink::SensorInitParamsPtr,
                        device::mojom::blink::SensorClientRequest);
 
   bool tryReadFromBuffer(device::SensorReading& result);
@@ skipping 14 matching lines @@
   mojo::ScopedSharedBufferMapping m_sharedBuffer;
   bool m_suspended;
   Member<SensorReading> m_reading;
   std::unique_ptr<SensorReadingFactory> m_readingFactory;
 
   using ReadingBuffer = device::SensorReadingSharedBuffer;
   static_assert(
       sizeof(ReadingBuffer) ==
           device::mojom::blink::SensorInitParams::kReadBufferSizeForTests,
       "Check reading buffer size for tests");
+
+  mojom::blink::PermissionStatus m_sensorPermission;

[Mikhail, 2016/11/10 09:30:48]

m_permissionStatus

[riju_, 2016/11/14 14:00:07]

Done.

+  mojom::blink::PermissionServicePtr m_permissionService;
+  Member<ExecutionContext> m_executionContext;
+  bool m_startPendingPermission;
 };
 
 }  // namespace blink
 
 #endif  // SensorProxy_h