[sensors] Add Permission guard to the generic sensor apis.

third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/sensor/SensorProviderProxy.h"
 
+#include "core/dom/ExecutionContext.h"
+#include "modules/permissions/PermissionUtils.h"
 #include "modules/sensor/SensorProxy.h"
 #include "modules/sensor/SensorReading.h"
 #include "platform/mojo/MojoHelper.h"
 #include "public/platform/InterfaceProvider.h"
 #include "public/platform/Platform.h"
 
 namespace blink {
 
 // SensorProviderProxy
 SensorProviderProxy::SensorProviderProxy(LocalFrame* frame) {
@@ skipping 18 matching lines @@
   return result;
 }
 
 SensorProviderProxy::~SensorProviderProxy() {}
 
 DEFINE_TRACE(SensorProviderProxy) {
   visitor->trace(m_sensors);
   Supplement<LocalFrame>::trace(visitor);
 }
 
+void SensorProviderProxy::onPermissionServiceConnectionError() {
+  if (!Platform::current()) {
+    // TODO(rockot): Clean this up once renderer shutdown sequence is fixed.
+    return;
+  }
+
+  m_permissionService.reset();
+  for (SensorProxy* sensor : m_sensors) {
+    sensor->handleSensorError(SecurityError,
+                              "Permission service not available.");
+  }
+}
+
 SensorProxy* SensorProviderProxy::createSensor(

[shalamov, 2016/11/16 19:03:49]

I think we should rename it to createSensorProxy. Mikhail wdyt?

     device::mojom::blink::SensorType type,
+    ExecutionContext* context,
     std::unique_ptr<SensorReadingFactory> readingFactory) {
   DCHECK(!getSensor(type));
 
-  SensorProxy* sensor = new SensorProxy(type, this, std::move(readingFactory));
+  // Get permission service.
+  if (connectToPermissionService(context,
+                                 mojo::GetProxy(&m_permissionService))) {
+    m_permissionService.set_connection_error_handler(convertToBaseCallback(
+        WTF::bind(&SensorProviderProxy::onPermissionServiceConnectionError,
+                  wrapWeakPersistent(this))));
+  }
+  if (!m_permissionService) {
+    for (SensorProxy* sensor : m_sensors) {
+      sensor->handleSensorError(

[shalamov, 2016/11/16 19:03:49]

Two comments:

1. At this point, m_sensors is empty, so, you can't notify sensors about an
error.

2. There is no return, therefore, you create sensor proxy anyways, even there is
no permission service available.

+          SecurityError,
+          "In its current state, the global scope can't request permissions");
+    }
+  }
+
+  RefPtr<SecurityOrigin> origin = context->getSecurityOrigin();
+  DCHECK(origin);
+  SensorProxy* sensor = new SensorProxy(type, m_permissionService.get(), origin,
+                                        this, std::move(readingFactory));
   m_sensors.add(sensor);
 
   return sensor;
 }
 
 SensorProxy* SensorProviderProxy::getSensor(
     device::mojom::blink::SensorType type) {
   for (SensorProxy* sensor : m_sensors) {
     // TODO(Mikhail) : Hash sensors by type for efficiency.
     if (sensor->type() == type)
       return sensor;
   }
 
   return nullptr;
 }
 
 void SensorProviderProxy::onSensorProviderConnectionError() {
   if (!Platform::current()) {
     // TODO(rockot): Clean this up once renderer shutdown sequence is fixed.
     return;
   }
 
   m_sensorProvider.reset();
   for (SensorProxy* sensor : m_sensors)
     sensor->handleSensorError();
 }
 
 }  // namespace blink