Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/a947a329b3030259fbd042458dd6f31b1fe79dcf
Description was changed from
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
==========
to
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========
liyuqian
Description was changed from ========== Turn on Analytic AA in Chrome Update cc_unittests png files ...
Description was changed from
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========
to
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========
Please have a look at this test rebaseline. This is the clean version of the
closed issue https://codereview.chromium.org/2407393003/ (That issue has too
many pngs (7000+) that cause some troubles with the rietveld.)
you have multiple reviewers, so please list which files you want each reviewer
to look at.
for these directories, pick owners for each one (i.e. webkit, skia, cc)
chromium-reviews
I added you as the reviewer because of the cc unit tests. Thankfully, ajuma has ...
I added you as the reviewer because of the cc unit tests. Thankfully, ajuma
has already reviewed them so I think that there's no work left :)
On Wed, Oct 26, 2016 at 4:05 PM, <jam@chromium.org> wrote:
> you have multiple reviewers, so please list which files you want each
> reviewer
> to look at.
>
> for these directories, pick owners for each one (i.e. webkit, skia, cc)
>
> https://codereview.chromium.org/2458433002/
>
--
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.
blink-reviews
I added you as the reviewer because of the cc unit tests. Thankfully, ajuma has ...
I added you as the reviewer because of the cc unit tests. Thankfully, ajuma
has already reviewed them so I think that there's no work left :)
On Wed, Oct 26, 2016 at 4:05 PM, <jam@chromium.org> wrote:
> you have multiple reviewers, so please list which files you want each
> reviewer
> to look at.
>
> for these directories, pick owners for each one (i.e. webkit, skia, cc)
>
> https://codereview.chromium.org/2458433002/
>
--
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.
commit-bot: I haz the power
Description was changed from ========== Turn on Analytic AA in Chrome Update cc_unittests png files ...
4 years, 1 month ago
(2016-10-27 02:24:58 UTC)
#10
Message was sent while issue was closed.
Description was changed from
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========
to
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org
Committed: https://crrev.com/a947a329b3030259fbd042458dd6f31b1fe79dcf
Patch from Yuqian Li <liyuqian@google.com>.
Cr-Commit-Position: refs/heads/master@{#427919}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a947a329b3030259fbd042458dd6f31b1fe79dcf Cr-Commit-Position: refs/heads/master@{#427919}
4 years, 1 month ago
(2016-10-27 02:24:59 UTC)
#11
Description was changed from ========== Turn on Analytic AA in Chrome Update cc_unittests png files ...
4 years, 1 month ago
(2016-10-27 02:26:28 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org
Committed: https://crrev.com/a947a329b3030259fbd042458dd6f31b1fe79dcf
Patch from Yuqian Li <liyuqian@google.com>.
Cr-Commit-Position: refs/heads/master@{#427919}
==========
to
==========
Turn on Analytic AA in Chrome
Update cc_unittests png files to reflect our changes.
We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.
BUG=
patch from issue 2407393003 at patchset 20001
(http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
R=ajuma@chromium.org, fmalita@chromium.org
Committed:
https://chromium.googlesource.com/chromium/src/+/a947a329b3030259fbd042458dd6...
==========
f(malita)
Committed patchset #1 (id:1) manually as a947a329b3030259fbd042458dd6f31b1fe79dcf (presubmit successful).
4 years, 1 month ago
(2016-10-27 02:26:29 UTC)
#13
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a947a329b3030259fbd042458dd6f31b1fe79dcf (presubmit successful).
alancutter (OOO until 2018)
On 2016/10/27 at 02:26:29, fmalita wrote: > Committed patchset #1 (id:1) manually as a947a329b3030259fbd042458dd6f31b1fe79dcf (presubmit ...
4 years, 1 month ago
(2016-10-27 06:28:05 UTC)
#14
Message was sent while issue was closed.
On 2016/10/27 at 02:26:29, fmalita wrote:
> Committed patchset #1 (id:1) manually as
a947a329b3030259fbd042458dd6f31b1fe79dcf (presubmit successful).
Not sure why this was landed manually when the try bots show it breaks layout
tests.
alancutter (OOO until 2018)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2447013005/ by alancutter@chromium.org. ...
4 years, 1 month ago
(2016-10-27 06:28:52 UTC)
#15
Issue 2458433002: Turn on Analytic AA in Chrome
(Closed)
Created 4 years, 1 month ago by liyuqian
Modified 4 years, 1 month ago
Reviewers: ajuma1, ajuma, jam1, jam, f(malita), reed1
Base URL:
Comments: 0
Chromium Code Reviews
Issue
2458433002:
Turn on Analytic AA in Chrome (Closed)
