Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2458403003: [Devtools] Added default width to canvas timeline in network panel exp (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
chowse, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added default width to canvas timeline in network panel exp This patch adds a default width to network canvas timeline experiment. By default with old timeline the width is apx 235px this patch makes the new timeline canvas 200px by default. This patch also changes the ordering in which resizing the timeline column resizes. Now it will always scale the grid instead of scaling the timeline. See: http://imgur.com/a/Uu5bZ R=chowse,dgozman BUG=660998 Committed: https://crrev.com/eb86f1ef66b5a1ea5c416ea9e9e39c3bc5f460d4 Cr-Commit-Position: refs/heads/master@{#428910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
allada
PTL
4 years, 1 month ago (2016-11-01 00:27:04 UTC) #2
chowse
On 2016/11/01 00:27:04, Blaise wrote: > PTL LGTM
4 years, 1 month ago (2016-11-01 00:40:27 UTC) #4
dgozman
lgtm
4 years, 1 month ago (2016-11-01 01:26:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458403003/1
4 years, 1 month ago (2016-11-01 01:54:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 01:59:28 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 02:01:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb86f1ef66b5a1ea5c416ea9e9e39c3bc5f460d4
Cr-Commit-Position: refs/heads/master@{#428910}

Powered by Google App Engine
This is Rietveld 408576698